]> git.itanic.dy.fi Git - linux-stable/commit
drm/msm: remove unnecessary NULL check
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 13 Oct 2023 08:25:15 +0000 (11:25 +0300)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Fri, 17 Nov 2023 23:32:49 +0000 (15:32 -0800)
commit56466f653cb59a8f46e991ad1e285f43afdca7d4
tree8f38a5e775b9495f437f19a630830549e1af6464
parent21133266ca12f82b6e59c9711258cca2097c167c
drm/msm: remove unnecessary NULL check

This NULL check was required when it was added, but we shuffled the code
around and now it's not.  The inconsistent NULL checking triggers a
Smatch warning:

    drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn:
    variable dereferenced before check 'mdp5_kms' (see line 782)

Fixes: 1f50db2f3e1e ("drm/msm/mdp5: move resource allocation to the _probe function")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/562559/
Link: https://lore.kernel.org/r/ZSj+6/J6YsoSpLak@kadam
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c