]> git.itanic.dy.fi Git - linux-stable/commit
serial: omap: Prevent DoS using unprivileged ioctl(TIOCSRS485)
authorPeter Hurley <peter@hurleysoftware.com>
Tue, 12 Jan 2016 23:14:46 +0000 (15:14 -0800)
committerSasha Levin <sasha.levin@oracle.com>
Sun, 28 Feb 2016 05:09:48 +0000 (00:09 -0500)
commit56819934d6148c68c85eb181f6153b36f028f99c
treef7003961cffd688fb30c06f9eaf00980da1b21ee
parent8b6349ec0eefde22c3348b65804e343be1245a59
serial: omap: Prevent DoS using unprivileged ioctl(TIOCSRS485)

[ Upstream commit 308bbc9ab838d0ace0298268c7970ba9513e2c65 ]

The omap-serial driver emulates RS485 delays using software timers,
but neglects to clamp the input values from the unprivileged
ioctl(TIOCSRS485). Because the software implementation busy-waits,
malicious userspace could stall the cpu for ~49 days.

Clamp the input values to < 100ms.

Fixes: 4a0ac0f55b18 ("OMAP: add RS485 support")
Cc: <stable@vger.kernel.org> # 3.12+
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/tty/serial/omap-serial.c