]> git.itanic.dy.fi Git - linux-stable/commit
PCI: vmd: Correct PCI Header Type Register's multi-function check
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 3 Oct 2023 12:52:58 +0000 (15:52 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 3 Oct 2023 16:54:47 +0000 (11:54 -0500)
commit5827e17d0555b566c32044b0632b46f9f95054fa
treedcdbffe7178c6099cbb60f5d87f7263c5a447603
parentb5fc04039b9578d8bcc46bf70bcfe6b137340aeb
PCI: vmd: Correct PCI Header Type Register's multi-function check

vmd_domain_reset() attempts to find whether the device may contain multiple
functions by checking 0x80 (Multi-Function Device), however, the hdr_type
variable has already been masked with PCI_HEADER_TYPE_MASK so the check can
never true.

To fix the issue, don't mask the read with PCI_HEADER_TYPE_MASK.

Fixes: 6aab5622296b ("PCI: vmd: Clean up domain before enumeration")
Link: https://lore.kernel.org/r/20231003125300.5541-2-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Nirmal Patel <nirmal.patel@linux.intel.com>
drivers/pci/controller/vmd.c