]> git.itanic.dy.fi Git - linux-stable/commit
signalfd: fix information leak in signalfd_copyinfo
authorAmanieu d'Antras <amanieu@gmail.com>
Thu, 6 Aug 2015 22:46:33 +0000 (15:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Aug 2015 03:51:42 +0000 (20:51 -0700)
commit5c233bffdb9ffd2c85d1f94ddd8be956ee2b353f
tree2ec9e8f6751dd9b550f75d12e2f928e95605fc59
parent22ab6a2be78db078b11cc478bfc99cdc8e0642cb
signalfd: fix information leak in signalfd_copyinfo

commit 3ead7c52bdb0ab44f4bb1feed505a8323cc12ba7 upstream.

This function may copy the si_addr_lsb field to user mode when it hasn't
been initialized, which can leak kernel stack data to user mode.

Just checking the value of si_code is insufficient because the same
si_code value is shared between multiple signals.  This is solved by
checking the value of si_signo in addition to si_code.

Signed-off-by: Amanieu d'Antras <amanieu@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/signalfd.c