]> git.itanic.dy.fi Git - linux-stable/commit
net: openvswitch: Fix Use-After-Free in ovs_ct_exit
authorHyunwoo Kim <v4bel@theori.io>
Mon, 22 Apr 2024 09:37:17 +0000 (05:37 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 25 Apr 2024 00:14:24 +0000 (17:14 -0700)
commit5ea7b72d4fac2fdbc0425cd8f2ea33abe95235b2
treec4bf203f244d76bcd8d07e88b43f701665c23021
parent5b5f724b05c550e10693a53a81cadca901aefd16
net: openvswitch: Fix Use-After-Free in ovs_ct_exit

Since kfree_rcu, which is called in the hlist_for_each_entry_rcu traversal
of ovs_ct_limit_exit, is not part of the RCU read critical section, it
is possible that the RCU grace period will pass during the traversal and
the key will be free.

To prevent this, it should be changed to hlist_for_each_entry_safe.

Fixes: 11efd5cb04a1 ("openvswitch: Support conntrack zone limit")
Signed-off-by: Hyunwoo Kim <v4bel@theori.io>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Aaron Conole <aconole@redhat.com>
Link: https://lore.kernel.org/r/ZiYvzQN/Ry5oeFQW@v4bel-B760M-AORUS-ELITE-AX
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/openvswitch/conntrack.c