]> git.itanic.dy.fi Git - linux-stable/commit
cassini: Fix a memory leak in the error handling path of cas_init_one()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 15 May 2023 19:09:11 +0000 (21:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 May 2023 11:42:11 +0000 (12:42 +0100)
commit60d8e8b88087d68e10c8991a0f6733fa2f963ff0
tree16df95b8bd5315d74d583dfd679c5839ea5f49a9
parent9e6aa389c814d20bbfa5aa4ba494ed629fb72ec1
cassini: Fix a memory leak in the error handling path of cas_init_one()

[ Upstream commit 412cd77a2c24b191c65ea53025222418db09817c ]

cas_saturn_firmware_init() allocates some memory using vmalloc(). This
memory is freed in the .remove() function but not it the error handling
path of the probe.

Add the missing vfree() to avoid a memory leak, should an error occur.

Fixes: fcaa40669cd7 ("cassini: use request_firmware")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/sun/cassini.c