]> git.itanic.dy.fi Git - linux-stable/commit
kselftest: dt: Stop relying on dirname to improve performance
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Mon, 22 Jan 2024 14:29:18 +0000 (11:29 -0300)
committerRob Herring <robh@kernel.org>
Mon, 22 Jan 2024 15:39:58 +0000 (09:39 -0600)
commit6154fb9c2134f8d9534b2de10491aa3a22f3c9ff
treeffb90ac8c1e13389a6c2430a443eca0ea0596e1f
parent935024212dafebe065ccb5c4d399f19e4b8dbb82
kselftest: dt: Stop relying on dirname to improve performance

When walking directory trees, instead of looking for specific files and
running dirname to get the parent folder, traverse all folders and
ignore the ones not containing the desired files. This avoids the need
to call dirname inside the loop, which drastically decreases run time:
Running locally on a mt8192-asurada-spherion, which reports 160 test
cases, has gone from 5.5s to 2.9s, while running remotely with an
nfsroot has gone from 13.5s to 5.5s.

This change has a side-effect, which is that the root DT node now
also shows in the output, even though it isn't expected to bind to a
driver. However there shouldn't be a matching driver for the board
compatible, so the end result will be just an extra skipped test:

ok 1 / # SKIP

Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/310391e8-fdf2-4c2f-a680-7744eb685177@sirena.org.uk
Fixes: 14571ab1ad21 ("kselftest: Add new test for detecting unprobed Devicetree devices")
Tested-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20240122-dt-kselftest-dirname-perf-fix-v2-1-f1630532fd38@collabora.com
Signed-off-by: Rob Herring <robh@kernel.org>
tools/testing/selftests/dt/test_unprobed_devices.sh