]> git.itanic.dy.fi Git - linux-stable/commit
memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()
authorLiang He <windhl@126.com>
Sat, 16 Jul 2022 03:13:24 +0000 (11:13 +0800)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tue, 16 Aug 2022 09:12:03 +0000 (12:12 +0300)
commit61b3c876c1cbdb1efd1f52a1f348580e6e14efb6
tree99f05ae203a74fca9a682fb45b3c3921c46bde41
parent568035b01cfb107af8d2e4bd2fb9aea22cf5b868
memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()

The break of for_each_available_child_of_node() needs a
corresponding of_node_put() when the reference 'child' is not
used anymore. Here we do not need to call of_node_put() in
fail path as '!match' means no break.

While the of_platform_device_create() will created a new
reference by 'child' but it has considered the refcounting.

Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220716031324.447680-1-windhl@126.com
drivers/memory/pl353-smc.c