]> git.itanic.dy.fi Git - linux-stable/commit
ARM: ux500: do not directly dereference __iomem
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 8 Nov 2022 12:37:55 +0000 (13:37 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 8 Nov 2022 20:13:56 +0000 (21:13 +0100)
commit65b0e307a1a9193571db12910f382f84195a3d29
tree804a671f14dc9527f078ce1053d4ab64b926eafc
parentb29ea0e7e8122a11e9336fb89e96ca7ccdb314ae
ARM: ux500: do not directly dereference __iomem

Sparse reports that calling add_device_randomness() on `uid` is a
violation of address spaces. And indeed the next usage uses readl()
properly, but that was left out when passing it toadd_device_
randomness(). So instead copy the whole thing to the stack first.

Fixes: 4040d10a3d44 ("ARM: ux500: add DB serial number to entropy pool")
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/202210230819.loF90KDh-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Link: https://lore.kernel.org/r/20221108123755.207438-1-Jason@zx2c4.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/soc/ux500/ux500-soc-id.c