]> git.itanic.dy.fi Git - linux-stable/commit
parisc: isa-eeprom - Fix loff_t usage
authorMichael Buesch <mb@bu3sch.de>
Mon, 20 Jul 2009 22:58:44 +0000 (22:58 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Sun, 16 Aug 2009 21:18:36 +0000 (14:18 -0700)
commit678af37c3b4195946ca3460477ba67fab6a750cf
treefed3fa00807782dd496981b02a7833f6012bd1c9
parent5f18da549f0277e1c867169a74b1365d24cc3a9e
parisc: isa-eeprom - Fix loff_t usage

commit 6b4dbcd86a9d464057fcc7abe4d0574093071fcc upstream.

loff_t is a signed type. If userspace passes a negative ppos, the "count"
range check is weakened. "count"s bigger than HPEE_MAX_LENGTH will pass the check.
Also, if ppos is negative, the readb(eisa_eeprom_addr + *ppos) will poke in random
memory.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/parisc/eisa_eeprom.c