]> git.itanic.dy.fi Git - linux-stable/commit
vhost: correctly check the return value of translate_desc() in log_used()
authorJason Wang <jasowang@redhat.com>
Tue, 19 Feb 2019 06:53:44 +0000 (14:53 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Feb 2019 08:08:06 +0000 (09:08 +0100)
commit67df61cef0ea269336234c0986fe983da22026fe
tree569dd894f0acbc7e08b1eb51271e9df48fdcabf9
parentbc2b63d41bbf2fb7552d17cb7f42360cd8d27ca8
vhost: correctly check the return value of translate_desc() in log_used()

[ Upstream commit 816db7663565cd23f74ed3d5c9240522e3fb0dda ]

When fail, translate_desc() returns negative value, otherwise the
number of iovs. So we should fail when the return value is negative
instead of a blindly check against zero.

Detected by CoverityScan, CID# 1442593:  Control flow issues  (DEADCODE)

Fixes: cc5e71075947 ("vhost: log dirty page correctly")
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/vhost/vhost.c