]> git.itanic.dy.fi Git - linux-stable/commit
net: rds: use maybe_get_net() when acquiring refcount on TCP sockets
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Thu, 5 May 2022 01:53:53 +0000 (10:53 +0900)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 May 2022 23:44:49 +0000 (16:44 -0700)
commit6997fbd7a3dafa754f81d541498ace35b43246d8
tree9903b4be70449cb3b8759040ed1b57bdf4d89ed4
parent68533eb1fb197a413fd8612ebb88e111ade3beac
net: rds: use maybe_get_net() when acquiring refcount on TCP sockets

Eric Dumazet is reporting addition on 0 problem at rds_tcp_tune(), for
delayed works queued in rds_wq might be invoked after a net namespace's
refcount already reached 0.

Since rds_tcp_exit_net() from cleanup_net() calls flush_workqueue(rds_wq),
it is guaranteed that we can instead use maybe_get_net() from delayed work
functions until rds_tcp_exit_net() returns.

Note that I'm not convinced that all works which might access a net
namespace are already queued in rds_wq by the moment rds_tcp_exit_net()
calls flush_workqueue(rds_wq). If some race is there, rds_tcp_exit_net()
will fail to wait for work functions, and kmem_cache_free() could be
called from net_free() before maybe_get_net() is called from
rds_tcp_tune().

Reported-by: Eric Dumazet <edumazet@google.com>
Fixes: 3a58f13a881ed351 ("net: rds: acquire refcount on TCP sockets")
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/41d09faf-bc78-1a87-dfd1-c6d1b5984b61@I-love.SAKURA.ne.jp
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rds/tcp.c
net/rds/tcp.h
net/rds/tcp_connect.c
net/rds/tcp_listen.c