]> git.itanic.dy.fi Git - linux-stable/commit
quota: Properly disable quotas when add_dquot_ref() fails
authorJan Kara <jack@suse.cz>
Mon, 5 Jun 2023 14:07:30 +0000 (22:07 +0800)
committerJan Kara <jack@suse.cz>
Mon, 5 Jun 2023 14:50:30 +0000 (16:50 +0200)
commit6a4e3363792e30177cc3965697e34ddcea8b900b
tree8097eb5b34039f81f2d5450c67f1366022e7cd8c
parentaac2fa20132e390e87270e3a738e86abcf1aea8b
quota: Properly disable quotas when add_dquot_ref() fails

When add_dquot_ref() fails (usually due to IO error or ENOMEM), we want
to disable quotas we are trying to enable. However dquot_disable() call
was passed just the flags we are enabling so in case flags ==
DQUOT_USAGE_ENABLED dquot_disable() call will just fail with EINVAL
instead of properly disabling quotas. Fix the problem by always passing
DQUOT_LIMITS_ENABLED | DQUOT_USAGE_ENABLED to dquot_disable() in this
case.

Reported-and-tested-by: Ye Bin <yebin10@huawei.com>
Reported-by: syzbot+e633c79ceaecbf479854@syzkaller.appspotmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
Message-Id: <20230605140731.2427629-2-yebin10@huawei.com>
fs/quota/dquot.c