]> git.itanic.dy.fi Git - linux-stable/commit
watchdog: at91sam9_wdt: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 6 Nov 2023 15:48:11 +0000 (16:48 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 17 Dec 2023 15:14:19 +0000 (16:14 +0100)
commit6a7b3de6a35a8bcdf28f33d70d2b30655da29a4d
tree3f543325ff17937463ce290e2fa778fdbd9f5061
parentde81f74b11e9ffdf5362961c2efea13bef11aefd
watchdog: at91sam9_wdt: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231106154807.3866712-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/at91sam9_wdt.c