]> git.itanic.dy.fi Git - linux-stable/commit
net: dsa: felix: fix taprio guard band overflow at 10Mbps with jumbo frames
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 13 Jun 2023 17:09:07 +0000 (20:09 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 15 Jun 2023 06:05:48 +0000 (23:05 -0700)
commit6ac7a27a8b07588497ed53dfd885df9c72bc67e0
treef7ef7f64c16cff696d895f2ebdb8d95fcfdfda49
parentc9a82bec02c339cdda99b37c5e62b3b71fc4209c
net: dsa: felix: fix taprio guard band overflow at 10Mbps with jumbo frames

The DEV_MAC_MAXLEN_CFG register contains a 16-bit value - up to 65535.
Plus 2 * VLAN_HLEN (4), that is up to 65543.

The picos_per_byte variable is the largest when "speed" is lowest -
SPEED_10 = 10. In that case it is (1000000L * 8) / 10 = 800000.

Their product - 52434400000 - exceeds 32 bits, which is a problem,
because apparently, a multiplication between two 32-bit factors is
evaluated as 32-bit before being assigned to a 64-bit variable.
In fact it's a problem for any MTU value larger than 5368.

Cast one of the factors of the multiplication to u64 to force the
multiplication to take place on 64 bits.

Issue found by Coverity.

Fixes: 55a515b1f5a9 ("net: dsa: felix: drop oversized frames with tc-taprio instead of hanging the port")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230613170907.2413559-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/ocelot/felix_vsc9959.c