]> git.itanic.dy.fi Git - linux-stable/commit
media: tuners: qt1010: replace BUG_ON with a regular error
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 20 Jul 2023 06:20:51 +0000 (08:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Sep 2023 08:47:05 +0000 (10:47 +0200)
commit6cae780862d221106626b2b5fb21a197f398c6ec
treeba072234674ab310fd2671c66d0c2bdd45ce20c3
parent7cc05caa0f2e8d8067e5d174ec039499b5966af8
media: tuners: qt1010: replace BUG_ON with a regular error

[ Upstream commit ee630b29ea44d1851bb6c903f400956604834463 ]

BUG_ON is unnecessary here, and in addition it confuses smatch.
Replacing this with an error return help resolve this smatch
warning:

drivers/media/tuners/qt1010.c:350 qt1010_init() error: buffer overflow 'i2c_data' 34 <= 34

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/tuners/qt1010.c