]> git.itanic.dy.fi Git - linux-stable/commit
firmware: arm_ffa: Fix FFA notifications cleanup path
authorSudeep Holla <sudeep.holla@arm.com>
Tue, 24 Oct 2023 10:56:20 +0000 (11:56 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 13 Nov 2023 11:51:26 +0000 (11:51 +0000)
commit6d67cbe67a86a87307df0c6fafa74394a6820ad6
treeb973ebe71b27d5abd29e305154279261eb9930a0
parentf4bfcaee34bc9527274710884f8d14039f3ee506
firmware: arm_ffa: Fix FFA notifications cleanup path

We allow the FF-A to be initialised successfully even when notification
fails. When the notification fails, ffa_notifications_cleanup() gets
called on the failure path.

However, the driver information about the notifications like the irq,
workqueues and cpu hotplug state for enabling and disabling percpu IRQ
are not cleared. This may result in unexpected behaviour during CPU
hotplug because of percpu IRQ being enabled and disabled or during the
driver removal when ffa_notifications_cleanup() gets executed again.

Fix the FFA notifications cleanup path by clearing all the notification
related driver information.

Link: https://lore.kernel.org/r/20231024-ffa-notification-fixes-v1-4-d552c0ec260d@arm.com
Tested-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_ffa/driver.c