]> git.itanic.dy.fi Git - linux-stable/commit
ext4: drop fast_commit from /proc/mounts
authorTheodore Ts'o <tytso@mit.edu>
Thu, 19 Nov 2020 20:36:25 +0000 (15:36 -0500)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 19 Nov 2020 20:41:57 +0000 (15:41 -0500)
commit704c2317cab5571da0e5763cd47ad07f8900aa76
tree6f55a40282fe6423242215140fb2ea0209aae166
parent09162bc32c880a791c6c0668ce0745cf7958f576
ext4: drop fast_commit from /proc/mounts

The options in /proc/mounts must be valid mount options --- and
fast_commit is not a mount option.  Otherwise, command sequences like
this will fail:

    # mount /dev/vdc /vdc
    # mkdir -p /vdc/phoronix_test_suite /pts
    # mount --bind /vdc/phoronix_test_suite /pts
    # mount -o remount,nodioread_nolock /pts
    mount: /pts: mount point not mounted or bad option.

And in the system logs, you'll find:

    EXT4-fs (vdc): Unrecognized mount option "fast_commit" or missing value

Fixes: 995a3ed67fc8 ("ext4: add fast_commit feature and handling for extended mount options")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c