]> git.itanic.dy.fi Git - linux-stable/commit
vfs: Revert spurious fix to spinning prevention in prune_icache_sb
authorSuleiman Souhlal <suleiman@google.com>
Sat, 13 Apr 2013 23:03:06 +0000 (16:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Apr 2013 04:27:26 +0000 (21:27 -0700)
commit7077c66b3ab3a1d336648cf88f54df43709ebac3
tree2afe6bfbe8770c1acd0bc4b715a46e0309b045ed
parenteced4ec1b69c8cc5428ef29b947376bc6d57c8ce
vfs: Revert spurious fix to spinning prevention in prune_icache_sb

commit 5b55d708335a9e3e4f61f2dadf7511502205ccd1 upstream.

Revert commit 62a3ddef6181 ("vfs: fix spinning prevention in prune_icache_sb").

This commit doesn't look right: since we are looking at the tail of the
list (sb->s_inode_lru.prev) if we want to skip an inode, we should put
it back at the head of the list instead of the tail, otherwise we will
keep spinning on it.

Discovered when investigating why prune_icache_sb came top in perf
reports of a swapping load.

Signed-off-by: Suleiman Souhlal <suleiman@google.com>
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/inode.c