]> git.itanic.dy.fi Git - linux-stable/commit
dax: Introduce alloc_dev_dax_id()
authorDan Williams <dan.j.williams@intel.com>
Sat, 3 Jun 2023 06:14:05 +0000 (23:14 -0700)
committerVishal Verma <vishal.l.verma@intel.com>
Fri, 23 Jun 2023 07:03:50 +0000 (01:03 -0600)
commit70aab281e18c68a1284bc387de127c2fc0bed3f8
treea111f3edcc97d178f4050f74fefe95f6bbeececd
parent82b4ceeccb89cfd0b03706f1b15e31a7db6a027d
dax: Introduce alloc_dev_dax_id()

The reference counting of dax_region objects is needlessly complicated,
has lead to confusion [1], and has hidden a bug [2]. Towards cleaning up
that mess introduce alloc_dev_dax_id() to minimize the holding of a
dax_region reference to only what dev_dax_release() needs, the
dax_region->ida.

Part of the reason for the mess was the design to dereference a
dax_region in all cases in free_dev_dax_id() even if the id was
statically assigned by the upper level dax_region driver. Remove the
need to call "is_static(dax_region)" by tracking whether the id is
dynamic directly in the dev_dax instance itself.

With that flag the dax_region pinning and release per dev_dax instance
can move to alloc_dev_dax_id() and free_dev_dax_id() respectively.

A follow-on cleanup address the unnecessary references in the dax_region
setup and drivers.

Fixes: 0f3da14a4f05 ("device-dax: introduce 'seed' devices")
Link: http://lore.kernel.org/r/20221203095858.612027-1-liuyongqiang13@huawei.com
Link: http://lore.kernel.org/r/3cf0890b-4eb0-e70e-cd9c-2ecc3d496263@hpe.com
Reported-by: Yongqiang Liu <liuyongqiang13@huawei.com>
Reported-by: Paul Cassella <cassella@hpe.com>
Reported-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Link: https://lore.kernel.org/r/168577284563.1672036.13493034988900989554.stgit@dwillia2-xfh.jf.intel.com
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
drivers/dax/bus.c
drivers/dax/dax-private.h