]> git.itanic.dy.fi Git - linux-stable/commit
Bluetooth: qca: fix NULL-deref on non-serdev suspend
authorJohan Hovold <johan+linaro@kernel.org>
Mon, 22 Apr 2024 13:57:47 +0000 (15:57 +0200)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Wed, 24 Apr 2024 20:26:17 +0000 (16:26 -0400)
commit73e87c0a49fda31d7b589edccf4c72e924411371
tree0670fde4cffcc8d6154ceda993cb25d72c54078f
parent18bdb386a1a30e7a3d7732a98e45e69cf6b5710d
Bluetooth: qca: fix NULL-deref on non-serdev suspend

Qualcomm ROME controllers can be registered from the Bluetooth line
discipline and in this case the HCI UART serdev pointer is NULL.

Add the missing sanity check to prevent a NULL-pointer dereference when
wakeup() is called for a non-serdev controller during suspend.

Just return true for now to restore the original behaviour and address
the crash with pre-6.2 kernels, which do not have commit e9b3e5b8c657
("Bluetooth: hci_qca: only assign wakeup with serial port support") that
causes the crash to happen already at setup() time.

Fixes: c1a74160eaf1 ("Bluetooth: hci_qca: Add device_may_wakeup support")
Cc: stable@vger.kernel.org # 5.13
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/hci_qca.c