]> git.itanic.dy.fi Git - linux-stable/commit
net/tcp_sigpool: Fix some off by one bugs
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 31 Oct 2023 09:51:09 +0000 (12:51 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 2 Nov 2023 05:28:09 +0000 (22:28 -0700)
commit74da77921333171766031ea213b11f1e650814f9
tree508765dcb193e3cc7f2fb8a58997db5e029b2790
parent19b3f72a41a8751e26bffc093bb7e1cef29ad579
net/tcp_sigpool: Fix some off by one bugs

The "cpool_populated" variable is the number of elements in the cpool[]
array that have been populated.  It is incremented in
tcp_sigpool_alloc_ahash() every time we populate a new element.
Unpopulated elements are NULL but if we have populated every element then
this code will read one element beyond the end of the array.

Fixes: 8c73b26315aa ("net/tcp: Prepare tcp_md5sig_pool for TCP-AO")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Safonov <dima@arista.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/ce915d61-04bc-44fb-b450-35fcc9fc8831@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/tcp_sigpool.c