]> git.itanic.dy.fi Git - linux-stable/commit
HID: make arrays usage and value to be the same
authorWill McVicker <willmcvicker@google.com>
Sat, 5 Dec 2020 00:48:48 +0000 (00:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Feb 2021 09:12:59 +0000 (10:12 +0100)
commit77344e18cf84b37548292f2adfdb22f89079e0a6
treec4048d8d7ec482645c8ef47ae4883d3c6a3eca19
parent3320bae8c115863b6f17993c2b7970f7f419da57
HID: make arrays usage and value to be the same

commit ed9be64eefe26d7d8b0b5b9fa3ffdf425d87a01f upstream.

The HID subsystem allows an "HID report field" to have a different
number of "values" and "usages" when it is allocated. When a field
struct is created, the size of the usage array is guaranteed to be at
least as large as the values array, but it may be larger. This leads to
a potential out-of-bounds write in
__hidinput_change_resolution_multipliers() and an out-of-bounds read in
hidinput_count_leds().

To fix this, let's make sure that both the usage and value arrays are
the same size.

Cc: stable@vger.kernel.org
Signed-off-by: Will McVicker <willmcvicker@google.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-core.c