]> git.itanic.dy.fi Git - linux-stable/commit
firmware: arm_scmi: Fix possible frequency truncation when using level indexing mode
authorSudeep Holla <sudeep.holla@arm.com>
Thu, 30 Nov 2023 20:43:43 +0000 (20:43 +0000)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 4 Dec 2023 12:33:44 +0000 (12:33 +0000)
commit77f5032e94f244ba08db51e17ca8f37bd7ff9acb
treed8973a87c51a6ac1eb7b05db8745a382b24b4cd7
parent8e3c98d9187e09274fc000a7d1a77b070a42d259
firmware: arm_scmi: Fix possible frequency truncation when using level indexing mode

The multiplier is already promoted to unsigned long, however the
frequency calculations done when using level indexing mode doesn't
use the multiplier computed. It instead hardcodes the multiplier
value of 1000 at all the usage sites.

Clean that up by assigning the multiplier value of 1000 when using
the perf level indexing mode and update the frequency calculations to
use the multiplier instead. It should fix the possible frequency
truncation for all the values greater than or equal to 4GHz on 64-bit
machines.

Fixes: 31c7c1397a33 ("firmware: arm_scmi: Add v3.2 perf level indexing mode support")
Reported-by: Sibi Sankar <quic_sibis@quicinc.com>
Closes: https://lore.kernel.org/all/20231129065748.19871-3-quic_sibis@quicinc.com/
Cc: Cristian Marussi <cristian.marussi@arm.com>
Link: https://lore.kernel.org/r/20231130204343.503076-2-sudeep.holla@arm.com
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_scmi/perf.c