]> git.itanic.dy.fi Git - linux-stable/commit
USB: usbip: fix potential out-of-bounds write
authorIgnat Korchagin <ignat.korchagin@gmail.com>
Thu, 17 Mar 2016 18:00:29 +0000 (18:00 +0000)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 30 Apr 2016 22:05:24 +0000 (00:05 +0200)
commit7ce55b83fbf2ff341aacfe825001d40e7bbccbe2
tree648d1a6511dbbab8654c2553c8ec8852d9dd6e9e
parent2897ac4a5bf460ed350675c44bef5ae9d679d748
USB: usbip: fix potential out-of-bounds write

commit b348d7dddb6c4fbfc810b7a0626e8ec9e29f7cbb upstream.

Fix potential out-of-bounds write to urb->transfer_buffer
usbip handles network communication directly in the kernel. When receiving a
packet from its peer, usbip code parses headers according to protocol. As
part of this parsing urb->actual_length is filled. Since the input for
urb->actual_length comes from the network, it should be treated as untrusted.
Any entity controlling the network may put any value in the input and the
preallocated urb->transfer_buffer may not be large enough to hold the data.
Thus, the malicious entity is able to write arbitrary data to kernel memory.

Signed-off-by: Ignat Korchagin <ignat.korchagin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[bwh: Backported to 3.2: adjust filename, context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/staging/usbip/usbip_common.c