]> git.itanic.dy.fi Git - linux-stable/commit
net: phy: mscc: remove unnecessary phydev locking
authorDavid Epping <david.epping@missinglinkelectronics.com>
Tue, 23 May 2023 15:31:07 +0000 (17:31 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 25 May 2023 05:14:10 +0000 (22:14 -0700)
commit7df0b33d7993338a06e4039ec025bb67851ee41d
tree1a83cfe1c7aa48e77e481cc7c9a69c66e76f3fe8
parentfb055ce4a9e3a115f5dc42011a97cf0cfc7820e4
net: phy: mscc: remove unnecessary phydev locking

Holding the struct phy_device (phydev) lock is unnecessary when
accessing phydev->interface in the PHY driver .config_init method,
which is the only place that vsc85xx_rgmii_set_skews() is called from.

The phy_modify_paged() function implements required MDIO bus level
locking, which can not be achieved by a phydev lock.

Signed-off-by: David Epping <david.epping@missinglinkelectronics.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/mscc/mscc_main.c