]> git.itanic.dy.fi Git - linux-stable/commit
gpiolib: Fix scope-based gpio_device refcounting
authorLukas Wunner <lukas@wunner.de>
Mon, 15 Jan 2024 15:05:26 +0000 (16:05 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 15 Jan 2024 17:41:29 +0000 (18:41 +0100)
commit832b371097eb928d077c827b8f117bf5b99d35c0
treeda67fb5f889b1329c5f3abc74474b26f03d37b45
parentd460e9c2075164e9b1fa9c4c95f8c05517bd8752
gpiolib: Fix scope-based gpio_device refcounting

Commit 9e4555d1e54a ("gpiolib: add support for scope-based management to
gpio_device") sought to add scope-based gpio_device refcounting, but
erroneously forgot a negation of IS_ERR_OR_NULL().

As a result, gpio_device_put() is not called if the gpio_device pointer
is valid (meaning the ref is leaked), but only called if the pointer is
NULL or an ERR_PTR().

While at it drop a superfluous trailing semicolon.

Fixes: 9e4555d1e54a ("gpiolib: add support for scope-based management to gpio_device")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
include/linux/gpio/driver.h