]> git.itanic.dy.fi Git - linux-stable/commit
ALSA: hda/ca0132 - Don't try loading firmware at resume when already failed
authorTakashi Iwai <tiwai@suse.de>
Sun, 10 Aug 2014 11:30:08 +0000 (13:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Sep 2014 23:34:13 +0000 (16:34 -0700)
commit85d526418933905bf0e94b6923c264d8f4aa17be
tree28ed4b7be549b7fe18a1a8bc94f14477f33803d9
parent1ce3b22b30dc69359499551799b0274400b05511
ALSA: hda/ca0132 - Don't try loading firmware at resume when already failed

commit e24aa0a4c5ac92a171d9dd74a8d3dbf652990d36 upstream.

CA0132 driver tries to reload the firmware at resume.  Usually this
works since the firmware loader core caches the firmware contents by
itself.  However, if the driver failed to load the firmwares
(e.g. missing files), reloading the firmware at resume goes through
the actual file loading code path, and triggers a kernel WARNING like:

 WARNING: CPU: 10 PID:11371 at drivers/base/firmware_class.c:1105 _request_firmware+0x9ab/0x9d0()

For avoiding this situation, this patch makes CA0132 skipping the f/w
loading at resume when it failed at probe time.

Reported-and-tested-by: Janek Kozicki <cosurgi@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/patch_ca0132.c