]> git.itanic.dy.fi Git - linux-stable/commit
sit: check if IPv6 enabled before calling ip6_err_gen_icmpv6_unreach()
authorHangbin Liu <liuhangbin@gmail.com>
Thu, 7 Feb 2019 10:36:11 +0000 (18:36 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 2 May 2019 20:41:49 +0000 (21:41 +0100)
commit869b83cb1c076d804679e08065626743d0b91e9d
tree5df494ac28beca7a10541d5822eccfaeb0088e99
parent1e29ce40e4f470233618e6e931e4d9be21ae6c8f
sit: check if IPv6 enabled before calling ip6_err_gen_icmpv6_unreach()

commit 173656accaf583698bac3f9e269884ba60d51ef4 upstream.

If we disabled IPv6 from the kernel command line (ipv6.disable=1), we should
not call ip6_err_gen_icmpv6_unreach(). This:

  ip link add sit1 type sit local 192.0.2.1 remote 192.0.2.2 ttl 1
  ip link set sit1 up
  ip addr add 198.51.100.1/24 dev sit1
  ping 198.51.100.2

if IPv6 is disabled at boot time, will crash the kernel.

v2: there's no need to use in6_dev_get(), use __in6_dev_get() instead,
    as we only need to check that idev exists and we are under
    rcu_read_lock() (from netif_receive_skb_internal()).

Reported-by: Jianlin Shi <jishi@redhat.com>
Fixes: ca15a078bd90 ("sit: generate icmpv6 error when receiving icmpv4 error")
Cc: Oussama Ghorbel <ghorbel@pivasoftware.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
net/ipv6/sit.c