]> git.itanic.dy.fi Git - linux-stable/commit
hsr: Prevent use after free in prp_create_tagged_frame()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 27 Oct 2023 12:19:01 +0000 (15:19 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 2 Nov 2023 05:26:04 +0000 (22:26 -0700)
commit876f8ab52363f649bcc74072157dfd7adfbabc0d
tree4ddaeb45f1799c128db39176b335933a9f483f7e
parent7b3ba18703a63f6fd487183b9262b08e5632da1b
hsr: Prevent use after free in prp_create_tagged_frame()

The prp_fill_rct() function can fail.  In that situation, it frees the
skb and returns NULL.  Meanwhile on the success path, it returns the
original skb.  So it's straight forward to fix bug by using the returned
value.

Fixes: 451d8123f897 ("net: prp: add packet handling support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/57af1f28-7f57-4a96-bcd3-b7a0f2340845@moroto.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/hsr/hsr_forward.c