]> git.itanic.dy.fi Git - linux-stable/commit
lockdep: Introduce in_softirq lockdep assert
authorYunsheng Lin <linyunsheng@huawei.com>
Tue, 24 Nov 2020 10:49:28 +0000 (18:49 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 25 Nov 2020 23:08:34 +0000 (15:08 -0800)
commit8b5536ad1216c47fb9b37ef2cd0cfa70d79d4645
tree501780f646449de753cb071f3b6bc6908961a5b4
parentb5094a3b535b5a258ab49ed9614948df63bc3557
lockdep: Introduce in_softirq lockdep assert

The current semantic for napi_consume_skb() is that caller need
to provide non-zero budget when calling from NAPI context, and
breaking this semantic will cause hard to debug problem, because
_kfree_skb_defer() need to run in atomic context in order to push
the skb to the particular cpu' napi_alloc_cache atomically.

So add the lockdep_assert_in_softirq() to assert when the running
context is not in_softirq, in_softirq means softirq is serving or
BH is disabled, which has a ambiguous semantics due to the BH
disabled confusion, so add a comment to emphasize that.

And the softirq context can be interrupted by hard IRQ or NMI
context, lockdep_assert_in_softirq() need to assert about hard
IRQ or NMI context too.

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/lockdep.h