]> git.itanic.dy.fi Git - linux-stable/commit
dmaengine: pl330: Return DMA_PAUSED when transaction is paused
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 26 May 2023 10:54:34 +0000 (13:54 +0300)
committerVinod Koul <vkoul@kernel.org>
Sun, 6 Aug 2023 18:31:41 +0000 (00:01 +0530)
commit8cda3ececf07d374774f6a13e5a94bc2dc04c26c
tree5f7df1a5054a6dfc3ac66962318c9c0a81a29e61
parente2dcbc330f46afb82fd49a6dcbb10f6cdcb466ec
dmaengine: pl330: Return DMA_PAUSED when transaction is paused

pl330_pause() does not set anything to indicate paused condition which
causes pl330_tx_status() to return DMA_IN_PROGRESS. This breaks 8250
DMA flush after the fix in commit 57e9af7831dc ("serial: 8250_dma: Fix
DMA Rx rearm race"). The function comment for pl330_pause() claims
pause is supported but resume is not which is enough for 8250 DMA flush
to work as long as DMA status reports DMA_PAUSED when appropriate.

Add PAUSED state for descriptor and mark BUSY descriptors with PAUSED
in pl330_pause(). Return DMA_PAUSED from pl330_tx_status() when the
descriptor is PAUSED.

Reported-by: Richard Tresidder <rtresidd@electromag.com.au>
Tested-by: Richard Tresidder <rtresidd@electromag.com.au>
Fixes: 88987d2c7534 ("dmaengine: pl330: add DMA_PAUSE feature")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/linux-serial/f8a86ecd-64b1-573f-c2fa-59f541083f1a@electromag.com.au/
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230526105434.14959-1-ilpo.jarvinen@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/pl330.c