]> git.itanic.dy.fi Git - linux-stable/commit
dt: dt-extract-compatibles: Don't follow symlinks when walking tree
authorNícolas F. R. A. Prado <nfraprado@collabora.com>
Tue, 7 Nov 2023 22:55:28 +0000 (17:55 -0500)
committerRob Herring <robh@kernel.org>
Thu, 9 Nov 2023 17:56:39 +0000 (11:56 -0600)
commit8f51593cdcab82fb23ef2e1a0010b2e6f99aae02
tree92c23b422aa0d1af6733db76cadeccca7e6faa55
parentfe612629746cf5cc7040529f780d46929605d0a6
dt: dt-extract-compatibles: Don't follow symlinks when walking tree

The iglob function, which we use to find C source files in the kernel
tree, always follows symbolic links. This can cause unintentional
recursions whenever a symbolic link points to a parent directory. A
common scenario is building the kernel with the output set to a
directory inside the kernel tree, which will contain such a symlink.

Instead of using the iglob function, use os.walk to traverse the
directory tree, which by default doesn't follow symbolic links. fnmatch
is then used to match the glob on the filename, as well as ignore hidden
files (which were ignored by default with iglob).

This approach runs just as fast as using iglob.

Fixes: b6acf8073517 ("dt: Add a check for undocumented compatible strings in kernel")
Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
Closes: https://lore.kernel.org/all/e90cb52f-d55b-d3ba-3933-6cc7b43fcfbc@arm.com
Signed-off-by: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Link: https://lore.kernel.org/r/20231107225624.9811-1-nfraprado@collabora.com
Signed-off-by: Rob Herring <robh@kernel.org>
scripts/dtc/dt-extract-compatibles