]> git.itanic.dy.fi Git - linux-stable/commit
sch_sfb: Also store skb len before calling child enqueue
authorToke Høiland-Jørgensen <toke@toke.dk>
Mon, 5 Sep 2022 19:21:36 +0000 (21:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 10:23:52 +0000 (12:23 +0200)
commit9021b4ede86d014daf505ac7a55f1b5b6c1c2fc5
treeded829623f3fbbde0f54fc421384481a86c0e71e
parente50b799a9dc26cf4c0b3237936f4c0f4bb28cae6
sch_sfb: Also store skb len before calling child enqueue

[ Upstream commit 2f09707d0c972120bf794cfe0f0c67e2c2ddb252 ]

Cong Wang noticed that the previous fix for sch_sfb accessing the queued
skb after enqueueing it to a child qdisc was incomplete: the SFB enqueue
function was also calling qdisc_qstats_backlog_inc() after enqueue, which
reads the pkt len from the skb cb field. Fix this by also storing the skb
len, and using the stored value to increment the backlog after enqueueing.

Fixes: 9efd23297cca ("sch_sfb: Don't assume the skb is still around after enqueueing to child")
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
Acked-by: Cong Wang <cong.wang@bytedance.com>
Link: https://lore.kernel.org/r/20220905192137.965549-1-toke@toke.dk
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_sfb.c