]> git.itanic.dy.fi Git - linux-stable/commit
PCI: xgene: Do PCI error check on own line & keep return value
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 11 Sep 2023 12:53:53 +0000 (15:53 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 10 Oct 2023 21:40:18 +0000 (16:40 -0500)
commit910ed628e511b8533e40b7e9119040c160848a57
tree58b44f5601e07d9029a791d2648e92af2af09a13
parentd15f18053e5cc5576af9e7eef0b2a91169b6326d
PCI: xgene: Do PCI error check on own line & keep return value

Instead of an "if" condition with a line split, use the usual error
handling pattern with a separate variable to improve readability.

pci_generic_config_read32() already returns either PCIBIOS_SUCCESSFUL or
PCIBIOS_DEVICE_NOT_FOUND so it is enough to simply return its return value
when ret != PCIBIOS_SUCCESSFUL.

No functional changes intended.

Link: https://lore.kernel.org/r/20230911125354.25501-6-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/controller/pci-xgene.c