]> git.itanic.dy.fi Git - linux-stable/commit
pwm: jz4740: Don't use dev_err_probe() in .request()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 6 Jan 2024 14:13:03 +0000 (15:13 +0100)
committerUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 12 Jan 2024 17:25:05 +0000 (18:25 +0100)
commit9320fc509b87b4d795fb37112931e2f4f8b5c55f
treee7bf0cfea9c0a81188936386af7395f274da7745
parenta297d07b9a1e4fb8cda25a4a2363a507d294b7c9
pwm: jz4740: Don't use dev_err_probe() in .request()

dev_err_probe() is only supposed to be used in probe functions. While it
probably doesn't hurt, both the EPROBE_DEFER handling and calling
device_set_deferred_probe_reason() are conceptually wrong in the request
callback. So replace the call by dev_err() and a separate return
statement.

This effectively reverts commit c0bfe9606e03 ("pwm: jz4740: Simplify
with dev_err_probe()").

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240106141302.1253365-2-u.kleine-koenig@pengutronix.de
Fixes: c0bfe9606e03 ("pwm: jz4740: Simplify with dev_err_probe()")
Cc: stable@vger.kernel.org
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/pwm/pwm-jz4740.c