]> git.itanic.dy.fi Git - linux-stable/commit
staging: rtl8192e: remove bogus ssid character sign test
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 25 Oct 2022 12:21:50 +0000 (14:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Oct 2022 17:13:48 +0000 (19:13 +0200)
commit937ec9f7d5f2625d60077bb7824fee35dc447c6e
tree26a4552fa7c471c1debbf6b0c230c3aa0447a755
parent9abf2313adc1ca1b6180c508c25f22f9395cc780
staging: rtl8192e: remove bogus ssid character sign test

This error triggers on some architectures with unsigned `char` types:

drivers/staging/rtl8192e/rtllib_softmac_wx.c:459 rtllib_wx_set_essid() warn: impossible condition '(extra[i] < 0) => (0-255 < 0)'

But actually, the entire test is bogus, as ssids don't have any sign
validity rules like that. So just remove this check look all together.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20221025122150.583617-1-Jason@zx2c4.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_softmac_wx.c