]> git.itanic.dy.fi Git - linux-stable/commit
netfilter: nf_conntrack_irc: Tighten matching on DCC message
authorDavid Leadbeater <dgl@dgl.cx>
Fri, 26 Aug 2022 04:56:57 +0000 (14:56 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:10:30 +0000 (11:10 +0200)
commit9a5d7e0acb41bb2aac552f8eeb4b404177f3f66d
treeee7fc58b49742e1cd34950a5cfb3c0d2897b2608
parent369ec4dab0972dd407d4ed9dae82f57a2a0fdf6e
netfilter: nf_conntrack_irc: Tighten matching on DCC message

[ Upstream commit e8d5dfd1d8747b56077d02664a8838c71ced948e ]

CTCP messages should only be at the start of an IRC message, not
anywhere within it.

While the helper only decodes packes in the ORIGINAL direction, its
possible to make a client send a CTCP message back by empedding one into
a PING request.  As-is, thats enough to make the helper believe that it
saw a CTCP message.

Fixes: 869f37d8e48f ("[NETFILTER]: nf_conntrack/nf_nat: add IRC helper port")
Signed-off-by: David Leadbeater <dgl@dgl.cx>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_conntrack_irc.c