]> git.itanic.dy.fi Git - linux-stable/commit
net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid
authorAnant Thazhemadam <anant.thazhemadam@gmail.com>
Mon, 12 Oct 2020 04:24:04 +0000 (09:54 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Nov 2020 10:08:44 +0000 (11:08 +0100)
commit9d5fa0ad46e7882bbf89cf40d57241de3307f380
treecd79701ee7f1af4109f69f460b36852a72343503
parent1712a5d8dc9105f98bd15b78a1d996c3c113c212
net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid

[ Upstream commit 7ca1db21ef8e0e6725b4d25deed1ca196f7efb28 ]

In p9_fd_create_unix, checking is performed to see if the addr (passed
as an argument) is NULL or not.
However, no check is performed to see if addr is a valid address, i.e.,
it doesn't entirely consist of only 0's.
The initialization of sun_server.sun_path to be equal to this faulty
addr value leads to an uninitialized variable, as detected by KMSAN.
Checking for this (faulty addr) and returning a negative error number
appropriately, resolves this issue.

Link: http://lkml.kernel.org/r/20201012042404.2508-1-anant.thazhemadam@gmail.com
Reported-by: syzbot+75d51fe5bf4ebe988518@syzkaller.appspotmail.com
Tested-by: syzbot+75d51fe5bf4ebe988518@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/9p/trans_fd.c