]> git.itanic.dy.fi Git - linux-stable/commit
jbd2: correctly unescape journal data blocks
authorDuane Griffin <duaneg@dghda.com>
Thu, 20 Mar 2008 02:45:05 +0000 (02:45 +0000)
committerChris Wright <chrisw@sous-sol.org>
Mon, 24 Mar 2008 18:48:03 +0000 (11:48 -0700)
commit9ecfdfeaf6210f17b93f4130845a9349ab893196
tree4fbb630e57dab3923f5aaa8b10676b2c5603d22e
parent6eb36c282b77ba9f392e7bc332f7fda80c310db6
jbd2: correctly unescape journal data blocks

commit: d00256766a0b4f1441931a7f569a13edf6c68200

Fix a long-standing typo (predating git) that will cause data corruption if a
journal data block needs unescaping.  At the moment the wrong buffer head's
data is being unescaped.

To test this case mount a filesystem with data=journal, start creating and
deleting a bunch of files containing only JBD2_MAGIC_NUMBER (0xc03b3998), then
pull the plug on the device.  Without this patch the files will contain zeros
instead of the correct data after recovery.

Signed-off-by: Duane Griffin <duaneg@dghda.com>
Acked-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/jbd2/recovery.c