]> git.itanic.dy.fi Git - linux-stable/commit
random: avoid reading two cache lines on irq randomness
authorJason A. Donenfeld <Jason@zx2c4.com>
Thu, 22 Sep 2022 16:46:04 +0000 (18:46 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Wed, 28 Sep 2022 16:17:30 +0000 (18:17 +0200)
commit9ee0507e896b45af6d65408c77815800bce30008
treeee7e977c2029f6710aaaa2df9f5c7a4addc9f7b6
parente78a802a7b4febf53f2a92842f494b01062d85a8
random: avoid reading two cache lines on irq randomness

In order to avoid reading and dirtying two cache lines on every IRQ,
move the work_struct to the bottom of the fast_pool struct. add_
interrupt_randomness() always touches .pool and .count, which are
currently split, because .mix pushes everything down. Instead, move .mix
to the bottom, so that .pool and .count are always in the first cache
line, since .mix is only accessed when the pool is full.

Fixes: 58340f8e952b ("random: defer fast pool mixing to worker")
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/random.c