]> git.itanic.dy.fi Git - linux-stable/commit
drm/ast: Remove existing framebuffers before loading driver
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 15 Nov 2018 10:42:16 +0000 (11:42 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Mon, 11 Feb 2019 17:54:06 +0000 (17:54 +0000)
commita0d0d8dfff72995c0a6db3ef107ca3136236f32f
treef7db9f0aed05cf6f187f6913492b5b24765b8895
parentfe85652f04cc785ac2aa93e4616c718bef953545
drm/ast: Remove existing framebuffers before loading driver

commit 5478ad10e7850ce3d8b7056db05ddfa3c9ddad9a upstream.

If vesafb attaches to the AST device, it configures the framebuffer memory
for uncached access by default. When ast.ko later tries to attach itself to
the device, it wants to use write-combining on the framebuffer memory, but
vesefb's existing configuration for uncached access takes precedence. This
results in reduced performance.

Removing the framebuffer's configuration before loding the AST driver fixes
the problem. Other DRM drivers already contain equivalent code.

Link: https://bugzilla.opensuse.org/show_bug.cgi?id=1112963
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Tested-by: Y.C. Chen <yc_chen@aspeedtech.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Tested-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Dave Airlie <airlied@redhat.com>
[bwh: Backported to 3.16: Use remove_conflicting_framebuffers()]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/gpu/drm/ast/ast_drv.c