]> git.itanic.dy.fi Git - linux-stable/commit
ARM: 9263/1: use .arch directives instead of assembler command line flags
authorNick Desaulniers <ndesaulniers@google.com>
Mon, 24 Oct 2022 19:44:41 +0000 (20:44 +0100)
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 8 Nov 2022 18:36:17 +0000 (18:36 +0000)
commita2faac39866d0313f3ca59c36a9f4e077faf4f53
treedc61ac59188ca8484ce96c572abfbd0a574df274
parent5aa4860eb50f3700e3175759f608bcfb68d0d6ae
ARM: 9263/1: use .arch directives instead of assembler command line flags

Similar to commit a6c30873ee4a ("ARM: 8989/1: use .fpu assembler
directives instead of assembler arguments").

GCC and GNU binutils support setting the "sub arch" via -march=,
-Wa,-march, target function attribute, and .arch assembler directive.

Clang was missing support for -Wa,-march=, but this was implemented in
clang-13.

The behavior of both GCC and Clang is to
prefer -Wa,-march= over -march= for assembler and assembler-with-cpp
sources, but Clang will warn about the -march= being unused.

clang: warning: argument unused during compilation: '-march=armv6k'
[-Wunused-command-line-argument]

Since most assembler is non-conditionally assembled with one sub arch
(modulo arch/arm/delay-loop.S which conditionally is assembled as armv4
based on CONFIG_ARCH_RPC, and arch/arm/mach-at91/pm-suspend.S which is
conditionally assembled as armv7-a based on CONFIG_CPU_V7), prefer the
.arch assembler directive.

Add a few more instances found in compile testing as found by Arnd and
Nathan.

Link: https://github.com/llvm/llvm-project/commit/1d51c699b9e2ebc5bcfdbe85c74cc871426333d4
Link: https://bugs.llvm.org/show_bug.cgi?id=48894
Link: https://github.com/ClangBuiltLinux/linux/issues/1195
Link: https://github.com/ClangBuiltLinux/linux/issues/1315
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
41 files changed:
arch/arm/boot/compressed/Makefile
arch/arm/common/Makefile
arch/arm/common/mcpm_head.S
arch/arm/common/vlock.S
arch/arm/kernel/Makefile
arch/arm/kernel/hyp-stub.S
arch/arm/kernel/swp_emulate.c
arch/arm/lib/Makefile
arch/arm/lib/delay-loop.S
arch/arm/mach-at91/Makefile
arch/arm/mach-at91/pm_suspend.S
arch/arm/mach-imx/Makefile
arch/arm/mach-imx/headsmp.S
arch/arm/mach-imx/resume-imx6.S
arch/arm/mach-imx/suspend-imx6.S
arch/arm/mach-mvebu/Makefile
arch/arm/mach-mvebu/coherency_ll.S
arch/arm/mach-mvebu/pmsu.c
arch/arm/mach-npcm/Makefile
arch/arm/mach-npcm/headsmp.S
arch/arm/mach-tegra/Makefile
arch/arm/mach-tegra/reset-handler.S
arch/arm/mach-tegra/sleep-tegra20.S
arch/arm/mach-tegra/sleep-tegra30.S
arch/arm/mach-tegra/sleep.S
arch/arm/mm/Makefile
arch/arm/mm/abort-ev6.S
arch/arm/mm/abort-ev7.S
arch/arm/mm/cache-v6.S
arch/arm/mm/cache-v7.S
arch/arm/mm/cache-v7m.S
arch/arm/mm/copypage-feroceon.c
arch/arm/mm/proc-v6.S
arch/arm/mm/proc-v7-2level.S
arch/arm/mm/proc-v7.S
arch/arm/mm/tlb-v6.S
arch/arm/mm/tlb-v7.S
drivers/memory/Makefile
drivers/memory/ti-emif-sram-pm.S
drivers/soc/bcm/brcmstb/pm/Makefile
drivers/soc/bcm/brcmstb/pm/s2-arm.S