]> git.itanic.dy.fi Git - linux-stable/commit
lib/xz: Validate the value before assigning it to an enum variable
authorLasse Collin <lasse.collin@tukaani.org>
Sun, 10 Oct 2021 21:31:40 +0000 (05:31 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:58:38 +0000 (11:58 +0100)
commita3cf8daf8c0927e3daec7b125cb73a3dce3901b6
treedd6ff380f16ebf76c5680b4d63e298e11dc99eee
parent6269497f1e13bb4e5fafdd4cc378d0fb60805d8d
lib/xz: Validate the value before assigning it to an enum variable

[ Upstream commit 4f8d7abaa413c34da9d751289849dbfb7c977d05 ]

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/xz/xz_dec_stream.c