]> git.itanic.dy.fi Git - linux-stable/commit
scsi: qla2xxx: Always wait for qlt_sess_work_fn() from qlt_stop_phase1()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sun, 21 Aug 2022 03:59:00 +0000 (12:59 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 1 Sep 2022 03:39:58 +0000 (23:39 -0400)
commita4345557527f7d9dab6684fc2d1dd7800e99d73a
tree2960db5be16c9b317c065387959c016ce4b2fe00
parent1b2b8d45ccd6a61f88c0d5a55c9119c3b710bfa5
scsi: qla2xxx: Always wait for qlt_sess_work_fn() from qlt_stop_phase1()

Currently qlt_stop_phase1() may fail to call flush_scheduled_work(), for
list_empty() may return true as soon as qlt_sess_work_fn() called
list_del(). In order to close this race window, check list_empty() after
calling flush_scheduled_work().

If this patch causes problems, please check commit c4f135d64382
("workqueue: Wrap flush_workqueue() using a macro"). We are on the way to
remove all flush_scheduled_work() calls from the kernel.

Link: https://lore.kernel.org/r/7f24469d-9e39-3398-d851-329b54c0b923@I-love.SAKURA.ne.jp
Tested-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_target.c