]> git.itanic.dy.fi Git - linux-stable/commit
ext4: fix race writing to an inline_data file while its xattrs are changing
authorTheodore Ts'o <tytso@mit.edu>
Sat, 21 Aug 2021 03:44:17 +0000 (23:44 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 31 Aug 2021 03:36:50 +0000 (23:36 -0400)
commita54c4613dac1500b40e4ab55199f7c51f028e848
treebc30df927da83ea3ac12345fcea64f104e6b8230
parentb33d9f5909c8d30f1429fb9aefbb32760901a023
ext4: fix race writing to an inline_data file while its xattrs are changing

The location of the system.data extended attribute can change whenever
xattr_sem is not taken.  So we need to recalculate the i_inline_off
field since it mgiht have changed between ext4_write_begin() and
ext4_write_end().

This means that caching i_inline_off is probably not helpful, so in
the long run we should probably get rid of it and shrink the in-memory
ext4 inode slightly, but let's fix the race the simple way for now.

Cc: stable@kernel.org
Fixes: f19d5870cbf72 ("ext4: add normal write support for inline data")
Reported-by: syzbot+13146364637c7363a7de@syzkaller.appspotmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inline.c