]> git.itanic.dy.fi Git - linux-stable/commit
staging: wlan-ng: fix exit return when sme->key_idx >= NUM_WEPKEYS
authorColin Ian King <colin.king@canonical.com>
Mon, 14 Oct 2019 11:02:01 +0000 (12:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 29 Oct 2019 08:15:19 +0000 (09:15 +0100)
commita56c80d8ee76daa1b7ce2e42e49f86e07aa5591a
tree1c0569da096a0dffb9ed72287113e066dd8349fa
parentbfdf982921b6f1bf99dfade9b7ef4e0bd4e67122
staging: wlan-ng: fix exit return when sme->key_idx >= NUM_WEPKEYS

commit 153c5d8191c26165dbbd2646448ca7207f7796d0 upstream.

Currently the exit return path when sme->key_idx >= NUM_WEPKEYS is via
label 'exit' and this checks if result is non-zero, however result has
not been initialized and contains garbage.  Fix this by replacing the
goto with a return with the error code.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 0ca6d8e74489 ("Staging: wlan-ng: replace switch-case statements with macro")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191014110201.9874-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wlan-ng/cfg80211.c