]> git.itanic.dy.fi Git - linux-stable/commit
ASoC: cs35l34: Fix GPIO name and drop legacy include
authorLinus Walleij <linus.walleij@linaro.org>
Fri, 1 Dec 2023 13:20:32 +0000 (14:20 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 1 Dec 2023 16:59:18 +0000 (16:59 +0000)
commita6122b0b4211d132934ef99e7b737910e6d54d2f
tree6d695b9c785ad0a98c91da32931591718fa729ad
parent50678d339d670a92658e5538ebee30447c88ccb3
ASoC: cs35l34: Fix GPIO name and drop legacy include

This driver includes the legacy GPIO APIs <linux/gpio.h> and
<linux/of_gpio.h> but does not use any symbols from any of
them.

Drop the includes.

Further the driver is requesting "reset-gpios" rather than
just "reset" from the GPIO framework. This is wrong because
the gpiolib core will add "-gpios" before processing the
request from e.g. device tree. Drop the suffix.

The last problem means that the optional RESET GPIO has
never been properly retrieved and used even if it existed,
but nobody noticed.

Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.")
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20231201-descriptors-sound-cirrus-v2-3-ee9f9d4655eb@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l34.c