]> git.itanic.dy.fi Git - linux-stable/commit
media: atomisp: ov2722: Fix GPIO1 polarity
authorHans de Goede <hdegoede@redhat.com>
Sat, 3 Dec 2022 15:44:21 +0000 (16:44 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Wed, 8 Feb 2023 07:24:35 +0000 (08:24 +0100)
commitaec221279a2934de5fbfb8d553fcedb522772d8f
treefbe5117ec48b1c64a442b34d522193cf7e3c82b8
parent3ddac68f667c15cd1f44a31285d44b2c1a01bfc7
media: atomisp: ov2722: Fix GPIO1 polarity

The comment claims the PWDN pin is active when pulled down in other words,
it is /power-down so it needs to be driven high to get the sensor
powered-up (not powered down) and flag is 1 when powering-up the sensor
so the ! is wrong, drop it.

This also matches with the schematics which I have which shows GPIO1 also
enables a 3.3v line to the sensor-module which controls the privacy-LED
and indeed before this patch the privacy LED was inverted from what it
should be (and the sensor did not work).

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c