]> git.itanic.dy.fi Git - linux-stable/commit
soc: qcom: smsm: Fix refcount leak bugs in qcom_smsm_probe()
authorLiang He <windhl@126.com>
Thu, 21 Jul 2022 13:52:16 +0000 (21:52 +0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 18 Aug 2022 19:13:46 +0000 (14:13 -0500)
commitaf8f6f39b8afd772fda4f8e61823ef8c021bf382
tree2ab489338bd4823ff5721f585532ba498de4447a
parent14af4ce084b5fb86f7a01167f54ec8517966b804
soc: qcom: smsm: Fix refcount leak bugs in qcom_smsm_probe()

There are two refcount leak bugs in qcom_smsm_probe():

(1) The 'local_node' is escaped out from for_each_child_of_node() as
the break of iteration, we should call of_node_put() for it in error
path or when it is not used anymore.
(2) The 'node' is escaped out from for_each_available_child_of_node()
as the 'goto', we should call of_node_put() for it in goto target.

Fixes: c97c4090ff72 ("soc: qcom: smsm: Add driver for Qualcomm SMSM")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220721135217.1301039-1-windhl@126.com
drivers/soc/qcom/smsm.c